Page 1 of 1

Device stuck in "suspend" and blocking USB port

Posted: Tue Jan 27, 2009 7:41 am
by xSmurf
Hello, I'm trying to implement this HID device that uses three data reports. The device works fine with the demo code running at 16Mhz on an Arduino NG board. When I use my code however the device often refuses to poll and the status on the host shows the device as suspended or the whole port going AWOL. it reads *sometimes* but nothing reliable, I just know it does read. I've tried adding a little flow control, but there's not much that could be blocking rx in the program routine at this point. I've also added hardware reset, but to no avail. When running with debug output I just don't seen any requests at all when the connection fails.

Here's what it looks like on the host side when the device stops responding:

Code: Select all

Low Speed device @ 3 (0x1D100000): .............................................   DigiTherm (did not respond to inquiry - 0xe00002ed, might be Suspended)

and

Code: Select all

Warning: cannot query product for device: usb_control_msg(DeviceRequestTO): unknown error


You can view my report descriptor, config and main code bellow. If anyone has any insight on the matter it would be more than gladly appreciated.

HID Descriptor

Code: Select all

#ifndef _USB_HID_REPORT_DEF_H_
#define _USB_HID_REPORT_DEF_H_
   #include "usbconfig.h"
   
   const PROGMEM int8_t usbHidReportDescriptor[USB_CFG_HID_REPORT_DESCRIPTOR_LENGTH] = {      /* USB report descriptor */
      0x06, 0x00, 0xff,            // USAGE_PAGE (Vendor Specific)
      0x09, 0x01,                  // USAGE (Vendor Usage 1)
      0xa1, 0x01,                  // COLLECTION (Application)
      0x85, 0x01,                  //   REPORT_ID (1) CALENDAR
      0x15, 0x00,                  //   LOGICAL_MINIMUM (0)
      0x26, 0xff, 0x00,            //   LOGICAL_MAXIMUM (255)
      0x75, 0x08,                  //   REPORT_SIZE (8)
      0x95, 0x6e, 0x01,            //   REPORT_COUNT (366)
      0x09, 0x00,                  //   USAGE (Undefined)
      0xb2, 0x02, 0x01,            //   FEATURE (Data,Var,Abs,Buf)
      0xc0,                     // END_COLLECTION
      0xa1, 0x01,                  // COLLECTION (Application)
      0x85, 0x01,                  //   REPORT_ID (2) STATUS
      0x15, 0x00,                  //   LOGICAL_MINIMUM (0)
      0x26, 0xff, 0x00,            //   LOGICAL_MAXIMUM (255)
      0x75, 0x08,                  //   REPORT_SIZE (8)
      0x95, 0x10,                  //   REPORT_COUNT (16)
      0x09, 0x00,                  //   USAGE (Undefined)
      0xb2, 0x02, 0x01,            //   FEATURE (Data,Var,Abs,Buf)
      0xc0,                     // END_COLLECTION
      0xa1, 0x01,                  // COLLECTION (Application)
      0x85, 0x02,                  //   REPORT_ID (3) CONFIG
      0x15, 0x00,                  //   LOGICAL_MINIMUM (0)
      0x26, 0xff, 0x00,            //   LOGICAL_MAXIMUM (255)
      0x75, 0x08,                  //   REPORT_SIZE (8)
      0x95, 0x07,                  //   REPORT_COUNT (7)
      0x09, 0x00,                  //   USAGE (Undefined)
      0xb2, 0x02, 0x01,            //   FEATURE (Data,Var,Abs,Buf)
      0xc0                     // END_COLLECTION
      
   };
   
#endif


usb config

Code: Select all

/* Name: usbconfig.h
 * Project: AVR USB driver
 * Author: Christian Starkjohann
 * Creation Date: 2005-04-01
 * Tabsize: 4
 * Copyright: (c) 2005 by OBJECTIVE DEVELOPMENT Software GmbH
 * License: GNU GPL v2 (see License.txt), GNU GPL v3 or proprietary (CommercialLicense.txt)
 * This Revision: $Id: usbconfig-prototype.h 692 2008-11-07 15:07:40Z cs $
 */

#ifndef __usbconfig_h_included__
#define __usbconfig_h_included__

/*
General Description:
This file is an example configuration (with inline documentation) for the USB
driver. It configures AVR-USB for USB D+ connected to Port D bit 2 (which is
also hardware interrupt 0 on many devices) and USB D- to Port D bit 4. You may
wire the lines to any other port, as long as D+ is also wired to INT0 (or any
other hardware interrupt, as long as it is the highest level interrupt, see
section at the end of this file).
*/

/* ---------------------------- Hardware Config ---------------------------- */

#define USB_CFG_IOPORTNAME      D
/* This is the port where the USB bus is connected. When you configure it to
 * "B", the registers PORTB, PINB and DDRB will be used.
 */
#define USB_CFG_DMINUS_BIT      3
/* This is the bit number in USB_CFG_IOPORT where the USB D- line is connected.
 * This may be any bit in the port.
 */
#define USB_CFG_DPLUS_BIT       2
/* This is the bit number in USB_CFG_IOPORT where the USB D+ line is connected.
 * This may be any bit in the port. Please note that D+ must also be connected
 * to interrupt pin INT0! [You can also use other interrupts, see section
 * "Optional MCU Description" below, or you can connect D- to the interrupt, as
 * it is required if you use the USB_COUNT_SOF feature. If you use D- for the
 * interrupt, the USB interrupt will also be triggered at Start-Of-Frame
 * markers every millisecond.]
 */
#ifndef USB_CFG_CLOCK_KHZ
#define USB_CFG_CLOCK_KHZ       16000
//#warning "Defaulting USB clock speed to 16000"
#endif
/* Clock rate of the AVR in MHz. Legal values are 12000, 12800, 15000, 16000,
 * 16500 and 20000. The 12.8 MHz and 16.5 MHz versions of the code require no
 * crystal, they tolerate +/- 1% deviation from the nominal frequency. All
 * other rates require a precision of 2000 ppm and thus a crystal!
 * Default if not specified: 12 MHz
 */

/* ----------------------- Optional Hardware Config ------------------------ */

/* #define USB_CFG_PULLUP_IOPORTNAME   D */
#define USB_CFG_PULLUP_IOPORTNAME   D
/* If you connect the 1.5k pullup resistor from D- to a port pin instead of
 * V+, you can connect and disconnect the device from firmware by calling
 * the macros usbDeviceConnect() and usbDeviceDisconnect() (see usbdrv.h).
 * This constant defines the port on which the pullup resistor is connected.
 */
/* #define USB_CFG_PULLUP_BIT          4 */
#define USB_CFG_PULLUP_BIT          4
/* This constant defines the bit number in USB_CFG_PULLUP_IOPORT (defined
 * above) where the 1.5k pullup resistor is connected. See description
 * above for details.
 */

/* --------------------------- Functional Range ---------------------------- */

#define USB_CFG_HAVE_INTRIN_ENDPOINT    1
/* Define this to 1 if you want to compile a version with two endpoints: The
 * default control endpoint 0 and an interrupt-in endpoint (any other endpoint
 * number).
 */
#define USB_CFG_HAVE_INTRIN_ENDPOINT3   0
/* Define this to 1 if you want to compile a version with three endpoints: The
 * default control endpoint 0, an interrupt-in endpoint 3 (or the number
 * configured below) and a catch-all default interrupt-in endpoint as above.
 * You must also define USB_CFG_HAVE_INTRIN_ENDPOINT to 1 for this feature.
 */
#define USB_CFG_EP3_NUMBER              3
/* If the so-called endpoint 3 is used, it can now be configured to any other
 * endpoint number (except 0) with this macro. Default if undefined is 3.
 */
/* #define USB_INITIAL_DATATOKEN           USBPID_DATA1 */
/* The above macro defines the startup condition for data toggling on the
 * interrupt/bulk endpoints 1 and 3. Defaults to USBPID_DATA1.
 * Since the token is toggled BEFORE sending any data, the first packet is
 * sent with the oposite value of this configuration!
 */
#define USB_CFG_IMPLEMENT_HALT          1
/* Define this to 1 if you also want to implement the ENDPOINT_HALT feature
 * for endpoint 1 (interrupt endpoint). Although you may not need this feature,
 * it is required by the standard. We have made it a config option because it
 * bloats the code considerably.
 */
#define USB_CFG_SUPPRESS_INTR_CODE     0
/* Define this to 1 if you want to declare interrupt-in endpoints, but don't
 * want to send any data over them. If this macro is defined to 1, functions
 * usbSetInterrupt() and usbSetInterrupt3() are omitted. This is useful if
 * you need the interrupt-in endpoints in order to comply to an interface
 * (e.g. HID), but never want to send any data. This option saves a couple
 * of bytes in flash memory and the transmit buffers in RAM.
 */
#define USB_CFG_INTR_POLL_INTERVAL      100
/* If you compile a version with endpoint 1 (interrupt-in), this is the poll
 * interval. The value is in milliseconds and must not be less than 10 ms for
 * low speed devices.
 */
#define USB_CFG_IS_SELF_POWERED         1
/* Define this to 1 if the device has its own power supply. Set it to 0 if the
 * device is powered from the USB bus.
 */
#define USB_CFG_MAX_BUS_POWER           20
/* Set this variable to the maximum USB bus power consumption of your device.
 * The value is in milliamperes. [It will be divided by two since USB
 * communicates power requirements in units of 2 mA.]
 */
#define USB_CFG_IMPLEMENT_FN_WRITE      1
/* Set this to 1 if you want usbFunctionWrite() to be called for control-out
 * transfers. Set it to 0 if you don't need it and want to save a couple of
 * bytes.
 */
#define USB_CFG_IMPLEMENT_FN_READ       1
/* Set this to 1 if you need to send control replies which are generated
 * "on the fly" when usbFunctionRead() is called. If you only want to send
 * data from a static buffer, set it to 0 and return the data from
 * usbFunctionSetup(). This saves a couple of bytes.
 */
#define USB_CFG_IMPLEMENT_FN_WRITEOUT   0
/* Define this to 1 if you want to use interrupt-out (or bulk out) endpoints.
 * You must implement the function usbFunctionWriteOut() which receives all
 * interrupt/bulk data sent to any endpoint other than 0. The endpoint number
 * can be found in 'usbRxToken'.
 */
#define USB_CFG_HAVE_FLOWCONTROL        1
/* Define this to 1 if you want flowcontrol over USB data. See the definition
 * of the macros usbDisableAllRequests() and usbEnableAllRequests() in
 * usbdrv.h.
 */
#define USB_CFG_LONG_TRANSFERS          1
/* Define this to 1 if you want to send/receive blocks of more than 254 bytes
 * in a single control-in or control-out transfer. Note that the capability
 * for long transfers increases the driver size.
 */
/* #define USB_RX_USER_HOOK(data, len)     if(usbRxToken == (uint8_t)USBPID_SETUP) blinkLED(); */
/* This macro is a hook if you want to do unconventional things. If it is
 * defined, it's inserted at the beginning of received message processing.
 * If you eat the received message and don't want default processing to
 * proceed, do a return after doing your things. One possible application
 * (besides debugging) is to flash a status LED on each packet.
 */
/* #define USB_RESET_HOOK(resetStarts)     if(!resetStarts){hadUsbReset();} */
/* This macro is a hook if you need to know when an USB RESET occurs. It has
 * one parameter which distinguishes between the start of RESET state and its
 * end.
 */
/* #define USB_SET_ADDRESS_HOOK()              hadAddressAssigned(); */
/* This macro (if defined) is executed when a USB SET_ADDRESS request was
 * received.
 */
#define USB_COUNT_SOF                   0
/* define this macro to 1 if you need the global variable "usbSofCount" which
 * counts SOF packets. This feature requires that the hardware interrupt is
 * connected to D- instead of D+.
 */
/* #ifdef __ASSEMBLER__
 * macro myAssemblerMacro
 *     in      YL, TCNT0
 *     sts     timer0Snapshot, YL
 *     endm
 * #endif
 * #define USB_SOF_HOOK                    myAssemblerMacro
 * This macro (if defined) is executed in the assembler module when a
 * Start Of Frame condition is detected. It is recommended to define it to
 * the name of an assembler macro which is defined here as well so that more
 * than one assembler instruction can be used. The macro may use the register
 * YL and modify SREG. If it lasts longer than a couple of cycles, USB messages
 * immediately after an SOF pulse may be lost and must be retried by the host.
 * What can you do with this hook? Since the SOF signal occurs exactly every
 * 1 ms (unless the host is in sleep mode), you can use it to tune OSCCAL in
 * designs running on the internal RC oscillator.
 * Please note that Start Of Frame detection works only if D- is wired to the
 * interrupt, not D+. THIS IS DIFFERENT THAN MOST EXAMPLES!
 */
#define USB_CFG_CHECK_DATA_TOGGLING     0
/* define this macro to 1 if you want to filter out duplicate data packets
 * sent by the host. Duplicates occur only as a consequence of communication
 * errors, when the host does not receive an ACK. Please note that you need to
 * implement the filtering yourself in usbFunctionWriteOut() and
 * usbFunctionWrite(). Use the global usbCurrentDataToken and a static variable
 * for each control- and out-endpoint to check for duplicate packets.
 */
#define USB_CFG_HAVE_MEASURE_FRAME_LENGTH   0
/* define this macro to 1 if you want the function usbMeasureFrameLength()
 * compiled in. This function can be used to calibrate the AVR's RC oscillator.
 */

/* -------------------------- Device Description --------------------------- */

#define  USB_CFG_VENDOR_ID       0xc0, 0x16
/* USB vendor ID for the device, low byte first. If you have registered your
 * own Vendor ID, define it here. Otherwise you use one of obdev's free shared
 * VID/PID pairs. Be sure to read USBID-License.txt for rules!
 */
#define  USB_CFG_DEVICE_ID       0xdf, 0x05 /* obdev's shared PID for HIDs */
/* This is the ID of the product, low byte first. It is interpreted in the
 * scope of the vendor ID. If you have registered your own VID with usb.org
 * or if you have licensed a PID from somebody else, define it here. Otherwise
 * you use obdev's free shared VID/PID pair. Be sure to read the rules in
 * USBID-License.txt!
 */
#define USB_CFG_DEVICE_VERSION  0x00, 0x01
/* Version number of the device: Minor number first, then major number.
 */
#define USB_CFG_VENDOR_NAME     'm', 'l', 'a', 'l', 'o', 'n', 'd', 'e', '.', 'n', 'e', 't'
#define USB_CFG_VENDOR_NAME_LEN 12
/* These two values define the vendor name returned by the USB device. The name
 * must be given as a list of characters under single quotes. The characters
 * are interpreted as Unicode (UTF-16) entities.
 * If you don't want a vendor name string, undefine these macros.
 * ALWAYS define a vendor name containing your Internet domain name if you use
 * obdev's free shared VID/PID pair. See the file USBID-License.txt for
 * details.
 */
#define USB_CFG_DEVICE_NAME     'D', 'i', 'g', 'i', 'T', 'h', 'e', 'r', 'm'
#define USB_CFG_DEVICE_NAME_LEN 9
/* Same as above for the device name. If you don't want a device name, undefine
 * the macros. See the file USBID-License.txt before you assign a name if you
 * use a shared VID/PID.
 */
/*#define USB_CFG_SERIAL_NUMBER   'N', 'o', 'n', 'e' */
/*#define USB_CFG_SERIAL_NUMBER_LEN   0 */
/* Same as above for the serial number. If you don't want a serial number,
 * undefine the macros.
 * It may be useful to provide the serial number through other means than at
 * compile time. See the section about descriptor properties below for how
 * to fine tune control over USB descriptors such as the string descriptor
 * for the serial number.
 */
#define USB_CFG_DEVICE_CLASS        0
#define USB_CFG_DEVICE_SUBCLASS     0
/* See USB specification if you want to conform to an existing device class.
 * Class 0xff is "vendor specific".
 */
#define USB_CFG_INTERFACE_CLASS     3
#define USB_CFG_INTERFACE_SUBCLASS  0
#define USB_CFG_INTERFACE_PROTOCOL  0
/* See USB specification if you want to conform to an existing device class or
 * protocol. The following classes must be set at interface level:
 * HID class is 3, no subclass and protocol required (but may be useful!)
 * CDC class is 2, use subclass 2 and protocol 1 for ACM
 */
#define USB_CFG_HID_REPORT_DESCRIPTOR_LENGTH    63
/* Define this to the length of the HID report descriptor, if you implement
 * an HID device. Otherwise don't define it or define it to 0.
 * If you use this define, you must add a PROGMEM character array named
 * "usbHidReportDescriptor" to your code which contains the report descriptor.
 * Don't forget to keep the array and this define in sync!
 */

/* #define USB_PUBLIC static */
/* Use the define above if you #include usbdrv.c instead of linking against it.
 * This technique saves a couple of bytes in flash memory.
 */

/* ------------------- Fine Control over USB Descriptors ------------------- */
/* If you don't want to use the driver's default USB descriptors, you can
 * provide our own. These can be provided as (1) fixed length static data in
 * flash memory, (2) fixed length static data in RAM or (3) dynamically at
 * runtime in the function usbFunctionDescriptor(). See usbdrv.h for more
 * information about this function.
 * Descriptor handling is configured through the descriptor's properties. If
 * no properties are defined or if they are 0, the default descriptor is used.
 * Possible properties are:
 *   + USB_PROP_IS_DYNAMIC: The data for the descriptor should be fetched
 *     at runtime via usbFunctionDescriptor(). If the usbMsgPtr mechanism is
 *     used, the data is in FLASH by default. Add property USB_PROP_IS_RAM if
 *     you want RAM pointers.
 *   + USB_PROP_IS_RAM: The data returned by usbFunctionDescriptor() or found
 *     in static memory is in RAM, not in flash memory.
 *   + USB_PROP_LENGTH(len): If the data is in static memory (RAM or flash),
 *     the driver must know the descriptor's length. The descriptor itself is
 *     found at the address of a well known identifier (see below).
 * List of static descriptor names (must be declared PROGMEM if in flash):
 *   char usbDescriptorDevice[];
 *   char usbDescriptorConfiguration[];
 *   char usbDescriptorHidReport[];
 *   char usbDescriptorString0[];
 *   int usbDescriptorStringVendor[];
 *   int usbDescriptorStringDevice[];
 *   int usbDescriptorStringSerialNumber[];
 * Other descriptors can't be provided statically, they must be provided
 * dynamically at runtime.
 *
 * Descriptor properties are or-ed or added together, e.g.:
 * #define USB_CFG_DESCR_PROPS_DEVICE   (USB_PROP_IS_RAM | USB_PROP_LENGTH(18))
 *
 * The following descriptors are defined:
 *   USB_CFG_DESCR_PROPS_DEVICE
 *   USB_CFG_DESCR_PROPS_CONFIGURATION
 *   USB_CFG_DESCR_PROPS_STRINGS
 *   USB_CFG_DESCR_PROPS_STRING_0
 *   USB_CFG_DESCR_PROPS_STRING_VENDOR
 *   USB_CFG_DESCR_PROPS_STRING_PRODUCT
 *   USB_CFG_DESCR_PROPS_STRING_SERIAL_NUMBER
 *   USB_CFG_DESCR_PROPS_HID
 *   USB_CFG_DESCR_PROPS_HID_REPORT
 *   USB_CFG_DESCR_PROPS_UNKNOWN (for all descriptors not handled by the driver)
 *
 * Note about string descriptors: String descriptors are not just strings, they
 * are Unicode strings prefixed with a 2 byte header. Example:
 * int  serialNumberDescriptor[] = {
 *     USB_STRING_DESCRIPTOR_HEADER(6),
 *     'S', 'e', 'r', 'i', 'a', 'l'
 * };
 */

#define USB_CFG_DESCR_PROPS_DEVICE                  0
#define USB_CFG_DESCR_PROPS_CONFIGURATION           0
#define USB_CFG_DESCR_PROPS_STRINGS                 0
#define USB_CFG_DESCR_PROPS_STRING_0                0
#define USB_CFG_DESCR_PROPS_STRING_VENDOR           0
#define USB_CFG_DESCR_PROPS_STRING_PRODUCT          0
#define USB_CFG_DESCR_PROPS_STRING_SERIAL_NUMBER    0
#define USB_CFG_DESCR_PROPS_HID                     0
#define USB_CFG_DESCR_PROPS_HID_REPORT              0
#define USB_CFG_DESCR_PROPS_UNKNOWN                 0

/* ----------------------- Optional MCU Description ------------------------ */

/* The following configurations have working defaults in usbdrv.h. You
 * usually don't need to set them explicitly. Only if you want to run
 * the driver on a device which is not yet supported or with a compiler
 * which is not fully supported (such as IAR C) or if you use a differnt
 * interrupt than INT0, you may have to define some of these.
 */
/* #define USB_INTR_CFG            MCUCR */
/* #define USB_INTR_CFG_SET        ((1 << ISC00) | (1 << ISC01)) */
/* #define USB_INTR_CFG_CLR        0 */
/* #define USB_INTR_ENABLE         GIMSK */
/* #define USB_INTR_ENABLE_BIT     INT0 */
/* #define USB_INTR_PENDING        GIFR */
/* #define USB_INTR_PENDING_BIT    INTF0 */
/* #define USB_INTR_VECTOR         SIG_INTERRUPT0 */

#endif /* __usbconfig_h_included__ */


main.cpp (some parts ommited)

Code: Select all

#include "main.h"
extern "C" {
#ifdef USB_ENABLED
#warning "USB Enabled"
   #include "usbdrv/usbdrv.h"
   #include "usbdrv/requests.h"       /* The custom request numbers we use */
   #include "usbdrv/oddebug.h"      /* This is also an example for using debug macros */
#endif
};

void setup(void)
{
   // Set all of PORTD as inputs
   DDRD   = 0x00 | DDRD;

   
   configInitStatus();
   updateSensors();
   // Readback previous config
   configSetDefault();
   //configGet();
   configSave();
   
   nextMillis = millis() + 2000;
   
}

void loop(void)
{
   
   if (millis() >= nextMillis) {
      nextMillis = millis() + 2000;
      updateSensors();
      systemStatus.clockIntegrity = !systemStatus.clockIntegrity;
   }
}

int main(void)
{
#ifdef USB_HAS_PREINIT
   usbPreInit();
#endif
   
   init();
   
   setup();
   
#ifdef WATCHDOG_ENABLED
   wdt_start();
#endif
   
   for (;;) {
#ifdef USB_ENABLED
      // re-enable all requests before looping
      if (usbAllRequestsAreDisabled()) usbEnableAllRequests();
      usbPoll();
#endif
#ifdef WATCHDOG_ENABLED
      // Make sure we always clear the wdt
      wdt_reset();
#endif
      loop();
#ifdef WATCHDOG_ENABLED
      wdt_reset();
#endif
   }
   
   return 0;
}

// Some functions ommited

#ifdef USB_ENABLED
/* ------------------------------------------------------------------------- */
/* ----------------------------- USB interface ----------------------------- */
/* ------------------------------------------------------------------------- */

void usbPreInit(void)
{
   usbInit();
   
   ATOMIC_BLOCK(ATOMIC_RESTORESTATE) {
      usbDeviceDisconnect();   /* enforce re-enumeration, do this while interrupts are disabled! */
   }
   
   uint8_t i = 0;
   while(--i) {      // fake USB disconnect for > 250 ms
      wdt_reset();   // if watchdog is active, reset it
      _delay_ms(1);   // library call -- has limited range
   }
   
   usbDeviceConnect();
}

/* usbFunctionRead() is called when the host requests a chunk of data from
 * the device. For more information see the documentation in usbdrv/usbdrv.h.
 */
uint8_t   usbFunctionRead(uint8_t *data, uint8_t len)
{
   if(len > bytesRemaining)
      len = bytesRemaining;
   eeprom_read_block(data, (uint8_t *)0 + currentAddress, len);
   currentAddress += len;
   bytesRemaining -= len;
   return len;
}

/* usbFunctionWrite() is called when the host sends a chunk of data to the
 * device. For more information see the documentation in usbdrv/usbdrv.h.
 */
uint8_t   usbFunctionWrite(uint8_t *data, uint8_t len)
{
   if(bytesRemaining == 0)
      return 1;            /* end of transfer */
   if(len > bytesRemaining)
      len = bytesRemaining;
   eeprom_write_block(data, (uint8_t *)0 + currentAddress, len);
   currentAddress += len;
   bytesRemaining -= len;
   return bytesRemaining == 0; /* return 1 if this was the last chunk */
}

/* ------------------------------------------------------------------------- */

usbMsgLen_t usbFunctionSetup(uint8_t data[8])
{
   usbRequest_t   *rq = (usbRequest_t *)((void *)data);
   
   /* HID class request */
   if ((rq->bmRequestType & USBRQ_TYPE_MASK) == USBRQ_TYPE_CLASS) {
      if (rq->bRequest == USBRQ_HID_GET_REPORT) {
         usbDisableAllRequests();
         
         /* wValue: ReportType (highbyte), ReportID (lowbyte) */
         switch (rq->wValue.bytes[0]) {
            case USB_REPORTID_CALENDAR:
               bytesRemaining = EEPROM_CALENDAR_SIZE;
               currentAddress = (uint16_t) &EECalendar;
               return USB_NO_MSG;   /* use usbFunctionRead() to obtain data */
            break;
            case USB_REPORTID_STATUS:
               usbMsgPtr = (uint8_t*)&systemStatus;
               return (usbMsgLen_t) sizeof(t_statusHolder);
            break;
            case USB_REPORTID_CONFIG:
               usbMsgPtr = (uint8_t*)&systemConfig;
               return (usbMsgLen_t) sizeof(t_configHolder);
            break;
            // Ping request
            default:
               uint8_t buff[] = {USB_CFG_DEVICE_ID};
               usbMsgPtr   = buff;
               return 2;
            break;
         }
      } else if (rq->bRequest == USBRQ_HID_SET_REPORT) {
         /* wValue: ReportType (highbyte), ReportID (lowbyte) */
         switch (rq->wValue.bytes[0]) {
            case USB_REPORTID_CALENDAR:
               bytesRemaining = EEPROM_CALENDAR_SIZE;
               currentAddress = (uint16_t) &EECalendar;
               return USB_NO_MSG;   /* use usbFunctionWrite() to write data */
            break;
            /*
            case USB_REPORTID_STATUS:
               usbMsgPtr = (uint8_t*)&systemStatus;
               return sizeof(t_statusHolder);
            break;
            */
            case USB_REPORTID_CONFIG:
               usbMsgPtr = (uint8_t*)&systemConfig;
               return (usbMsgLen_t) sizeof(t_configHolder);
            break;
         }
      }
   } else {
      /* ignore vendor type requests, we don't use any */
   }
   
   if (usbAllRequestsAreDisabled()) usbEnableAllRequests();
   
   return 0;
}
#endif

Posted: Tue Jan 27, 2009 8:27 pm
by xSmurf
Here are a couple logs from the device. The first one shows the mcu starting up, connecting, allowing some data to be polled and then nothing, can't poll anymore. The others are from times where it plainly doesn't work.

Code: Select all

00:
ff:
[last message repeated 600 times]
ff:
1d: 80 06 00 01 00 00 08 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 00 00
1d: 00 05 03 00 00 00 00 00
20: 4b 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 01 03 09 04 02 00
20: 4b 1a 03 b5 2e
1d: 80 06 01 03 09 04 1a 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 00 09 01 00 00 00 00 00
20: 4b 00 00
1d: 81 06 00 22 00 00 3f 00
20: 4b 06 00 ff 09 01 a1 01 85 67 fd
20: c3 01 15 00 26 ff 00 75 08 24 7c
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 01 03 09 04 02 00
20: 4b 1a 03 b5 2e
1d: 80 06 01 03 09 04 1a 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 81 06 00 22 00 00 3f 00
20: 4b 06 00 ff 09 01 a1 01 85 67 fd
20: c3 01 15 00 26 ff 00 75 08 24 7c
20: 4b 95 6e 01 09 00 b2 02 01 44 36
20: c3 c0 a1 01 85 01 15 00 26 5e 83
20: 4b ff 00 75 08 95 10 09 00 30 0d
20: c3 b2 02 01 c0 a1 01 85 02 86 34
20: 4b 15 00 26 ff 00 75 08 95 bb a0
20: c3 07 09 00 b2 02 01 c0 15 de
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 00 02 00 00 08 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 01 03 09 04 ff 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 02 03 09 04 ff 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: a0 01 02 03 00 00 10 00
50: 01
20: 4b 13 10 f4 00 20 17 00 00 41 9c
20: c3 00 00 1a 02 1b 02 00 00 63 2a
20: 4b 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 00 02 00 00 08 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 01 03 09 04 ff 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 02 03 09 04 ff 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 02 03 09 04 00 01
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: a0 01 02 03 00 00 10 00
50: 01
20: 4b 13 10 f4 00 20 17 00 00 41 9c
20: c3 00 00 1a 02 1b 02 00 00 63 2a
20: 4b 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 00 02 00 00 08 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 00 00
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 01 03 09 04 ff 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 02 03 09 04 ff 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: a0 01 03 03 00 00 08 00
50: 01
20: 4b 14 01 04 02 c2 01 f3 00 ff 07
20: c3 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 00 02 00 00 08 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 01 03 09 04 ff 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 02 03 09 04 ff 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: a0 01 02 03 00 00 10 00
50: 01
20: 4b 13 10 f4 00 20 17 00 00 41 9c
20: c3 00 00 1a 02 1b 02 00 00 63 2a
20: 4b 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 00 02 00 00 08 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 00 00
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 01 03 09 04 ff 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 03 00 00 ff 00
20: 4b 04 03 09 04 09 78
1d: 80 06 02 03 09 04 ff 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33


Code: Select all

00:
ff:
[Last message repeated 576 times]
ff:
1d: 80 06 00 01 00 00 08 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 00 00
1d: 00 05 03 00 00 00 00 00
20: 4b 00 00
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 01 03 09 04 02 00
20: 4b 1a 03 b5 2e
1d: 80 06 01 03 09 04 1a 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 00 09 01 00 00 00 00 00
20: 4b 00 00
1d: 81 06 00 22 00 00 3f 00
20: 4b 06 00 ff 09 01 a1 01 85 67 fd
20: c3 01 15 00 26 ff 00 75 08 24 7c
20: 4b 95 6e 01 09 00 b2 02 01 44 36
20: c3 c0 a1 01 85 01 15 00 26 5e 83
20: 4b ff 00 75 08 95 10 09 00 30 0d
20: c3 b2 02 01 c0 a1 01 85 02 86 34
20: 4b 15 00 26 ff 00 75 08 95 bb a0


At this point I had no more data coming from the host. I did refresh a couple times in USB Prober (tool included with the OS X dev tools) here's the output:

Code: Select all

1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 01 03 09 04 02 00
20: 4b 1a 03 b5 2e
1d: 80 06 01 03 09 04 1a 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 81 06 00 22 00 00 3f 00
20: 4b 06 00 ff 09 01 a1 01 85 67 fd
20: c3 01 15 00 26 ff 00 75 08 24 7c
20: 4b 95 6e 01 09 00 b2 02 01 44 36
20: c3 c0 a1 01 85 01 15 00 26 5e 83
20: 4b ff 00 75 08 95 10 09 00 30 0d
20: c3 b2 02 01 c0 a1 01 85 02 86 34
20: 4b 15 00 26 ff 00 75 08 95 bb a0
20: c3 07 09 00 b2 02 01 c0 15 de
1d: 80 06 00 01 00 00 12 00
20: 4b 12 01 10 01 00 00 00 08 11 77
20: c3 c0 16 df 05 00 01 01 02 ca 9b
20: 4b 00 01 3f 8f
1d: 80 06 01 03 09 04 02 00
20: 4b 1a 03 b5 2e
1d: 80 06 01 03 09 04 1a 00
20: 4b 1a 03 6d 00 6c 00 61 00 31 fa
20: c3 6c 00 6f 00 6e 00 64 00 86 fe
20: 4b 65 00 2e 00 6e 00 65 00 48 15
20: c3 74 00 d9 4f
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 02 03 09 04 02 00
20: 4b 14 03 b1 4e
1d: 80 06 02 03 09 04 14 00
20: 4b 14 03 44 00 69 00 67 00 b4 e3
20: c3 69 00 54 00 68 00 65 00 43 52
20: 4b 72 00 6d 00 c8 33
1d: 80 06 00 02 00 00 04 00
20: 4b 09 02 22 00 45 27
1d: 80 06 00 02 00 00 22 00
20: 4b 09 02 22 00 01 01 00 40 0b 10
20: c3 0a 09 04 00 00 01 03 00 f6 3f
20: 4b 00 00 09 21 01 01 00 01 92 96
20: c3 22 3f 00 07 05 81 03 08 17 24
20: 4b 00 0a 7e 48
1d: 81 06 00 22 00 00 3f 00
20: 4b 06 00 ff 09 01 a1 01 85 67 fd
20: c3 01 15 00 26 ff 00 75 08 24 7c
20: 4b 95 6e 01 09 00 b2 02 01 44 36
20: c3 c0 a1 01 85 01 15 00 26 5e 83
20: 4b ff 00 75 08 95 10 09 00 30 0d
20: c3 b2 02 01 c0 a1 01 85 02 86 34
20: 4b 15 00 26 ff 00 75 08 95 bb a0
20: c3 07 09 00 b2 02 01 c0 15 de

Posted: Thu Jan 29, 2009 12:26 am
by xSmurf
Apparently the timer0 interrupt (from millis of the Arduino API) was interfering with the usb functions! It works great now! I'll need to do some more test, maybe up the prescaller because I still need some timing functionalities. Or maybe you can point me to where it should be disabled so it doesn't affect the usb routines.

Posted: Tue Feb 03, 2009 3:25 pm
by christian
You need to declare all Arduino interrupts with __attribute__((interrupt)) so that they can be interrupted by USB traffic.

The timer0 ISR is not well optimized, BTW, which makes the problem worse. And much of the Arduino code contains cli() sections, some of them long enough to cause problems with USB.

Posted: Fri Feb 06, 2009 9:01 am
by xSmurf
Hey christian, thanks for the input. I've tried a couple different things so far with some good result.
1) Changing the timer0 prescaler to 1024
2) Modifying the disabled/renable interrupts routine in the millis code to touch only timer0's interrupt (see diff below).

The second solution works nicely. There shouldn't be any other interrupts modifying the overflow counter variable so there's no chance of a non atomic dual register read error. This method proved to be stable with polling of ~16bytes every half second (and right now I want it way higher because libusb hugs like 50% of cpu when it polls). I'll also be using flow control for anything that requires a blocking delay of more than a couple ms. I'll be using a 20Mhz crystal in my final circuit, that should help reduce the time spent in the ISR also.

I have yet to try the attribute or try the modified ISR routine you gave Phil (follower).

I'm guessing this is happening because of the timer0 interrupt happening while the device is reading the host's request and/or sending the descriptor to the host.

Code: Select all

<   uint8_t oldSREG = SREG;
<   cli();
-
>   TIMSK0&=!(1<<TOIE0);
-
<   SREG = oldSREG;
-
>#if defined(__AVR_ATmega8__)
>   sbi(TIMSK, TOIE0);
>#else
>   sbi(TIMSK0, TOIE0);
>#endif

Posted: Fri Feb 06, 2009 12:40 pm
by christian
When you change the Timer0 prescaler, you change the timing unless you also modify the code. With a prescaler of 64, you get ca. one interrupt every 1 ms, that should not cause problems when you declare the ISR as ISR_NOBLOCK.

Disabling the Timer0 overflow interrupt only instead of cli() is a good idea. This should be fine for reading the global milliseconds variable.

You must be careful, though, with the implementation of the microseconds delay. This routine reads the timer value directly and compensates for overflow. The code may break if the delay between timer read and check for interrupt pending is too high. A USB interrupt between these two operations would cause an error.

If you want polling which does not require any CPU time, consider an interrupt endpoint. It's polled by the USB controller.

I'm guessing this is happening because of the timer0 interrupt happening while the device is reading the host's request and/or sending the descriptor to the host.

It's the other way around: The USB interrupt occurs while the timer interrupt is running and won't be handled before the ISR finishes, which is too late.